Dockerize Fill Station Binary #24
Merged
+155
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ZachGarcia42 and the rest of your teammates on |
ZachGarcia42
force-pushed
the
09-16-dockerize_fill_station_binary
branch
16 times, most recently
from
cd48b0f
to
5da146f
Compare
ZachGarcia42
requested review from
cameron-goddard and
nragland
as code owners
maxslarsson
reviewed
Sep 16, 2024
ZachGarcia42
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
5da146f
to
eff1be8
Compare
maxslarsson
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
eff1be8
to
51379a8
Compare
ZachGarcia42
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
51379a8
to
a04f64a
Compare
ZachGarcia42
commented
Sep 19, 2024
There was a problem hiding this comment.
Thanks @maxslarsson for the help! Ignore what I was saying about bazelisk being deprecated. That was for github actions not docker, so this seems great!
maxslarsson
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
a04f64a
to
c19ecb5
Compare
This was referenced Sep 19, 2024
Merged
maxslarsson
requested changes
Sep 19, 2024
maxslarsson
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
c19ecb5
to
deb282e
Compare
ZachGarcia42
force-pushed
the
09-16-dockerize_fill_station_binary
branch
from
deb282e
to
aa6c245
Compare
maxslarsson
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerize the fill station binary and add GitHub Actions automation to build the binary, place it in a docker image, and push that image to ghcr. This fixes #21